[codex] Fix no-services location search - #204
Draft
doobneek wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noServicesthrough allLocation.search()calls tofindUniqueLocationIds, including non-radius organization searches and count queries.noServicesin/locationsquery validation.Root cause
/locations?organizationName=...&noServices=trueparsed the flag at the controller, but the non-radiusLocation.search()branch did not pass it into the internal ID lookup. That kept the Service join required and filtered out service-less locations.Validation
npm run buildnpx jest --runInBand --coverage test/unit/location-search.test.js test/unit/phones.test.jsnpx eslint src/controllers/validation/locations.js test/integration/find-locations.test.js test/setup.js test/unit/location-search.test.jsNotes
--no-verifyafter the scoped checks above passed.